Skip to content

fix error generated by toggling split editor #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2018
Merged

fix error generated by toggling split editor #2487

merged 2 commits into from
Oct 23, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Oct 11, 2018

This changes fixes the error generated by toggling the split editor.

screenshot

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 13, 2018
ZeroX-DG
ZeroX-DG approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Sorry for this bug, this is due to my last PR, I was a bit lazy on that day 😄 Thanks a lot.

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 16, 2018
@Rokt33r Rokt33r added next release (v0.11.11) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Oct 23, 2018
@Rokt33r Rokt33r merged commit f92da16 into BoostIO:master Oct 23, 2018
@daiyam daiyam deleted the fix-task-config branch November 27, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daiyam @ZeroX-DG @Rokt33r