Skip to content

Add text-overflow: ellipsis to FolderItem #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2018
Merged

Add text-overflow: ellipsis to FolderItem #2412

merged 2 commits into from
Sep 30, 2018
+14 −5

Conversation

brapifra
Copy link
Contributor

Fixes #2409

@ZeroX-DG ZeroX-DG added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Sep 21, 2018
@ZeroX-DG
Copy link
Member

Hey @brapifra , can you improve your code a bit? This is the current behavior:
bbs

@brapifra
Copy link
Contributor Author

@ZeroX-DG I ended up changing the layout to flexbox. Let me know what u think.

ZeroX-DG
ZeroX-DG approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say: What if people use IE? Haha. Anyway, LGTM 🎉 Thank you.

@ZeroX-DG ZeroX-DG added next release (v0.11.10) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Sep 23, 2018
@Rokt33r Rokt33r merged commit 8eb5351 into BoostIO:master Sep 30, 2018
@ZeroX-DG ZeroX-DG mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brapifra @ZeroX-DG @Rokt33r