remove volatile hash from note links - #1623 #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rokt33r
approved these changes
Mar 12, 2018
mirsch
added a commit
to mirsch/Boostnote
that referenced
this pull request
Mar 12, 2018
…lect changes from BoostIO#1636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion to resolve #1623. It changes the hash (and filenames) for notes from 20 character hash to an uuid.
Filename before:
fc16de274b5ac2d604ed.csonnew filenamece53287e-a77c-49c1-9d41-5d9fb0d60a3b.csonthe change is backwards compatible. Old filenames can still be loaded.Note: it will break in very rare cases if you have the same filename/hash in multiple stores.
Not only in links but also inside the application the combination of storage.key and note.key was used. Multiple times both keys were concatenated and split again. I also removed this because the uuid is global unique and not by storage. The same applies to folders, but that's not in the scope of this PR.