Skip to content

Conversation

wadjoh
Copy link
Contributor

@wadjoh wadjoh commented Dec 11, 2017

Implements feature request in #838. This is something I missed from the editor, as well.
CodeMirror has a scrollPastEnd addon and I just added a checkbox in the UI tab of Preferences to enable it in the code editor.

@kazup01
Copy link
Member

kazup01 commented Dec 11, 2017

Cool! Thanks @Hooskers 🎉

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Dec 11, 2017
@kazup01 kazup01 requested a review from sota1235 December 11, 2017 08:57
Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sota1235 sota1235 removed their assignment Dec 13, 2017
@sota1235 sota1235 requested a review from kazup01 December 13, 2017 15:51
@sota1235 sota1235 removed the awaiting review ❇️ Pull request is awaiting a review. label Dec 13, 2017
@sota1235
Copy link
Contributor

@kazup01 could you confirm how does it work and merge?

Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine :)

@kazup01 kazup01 merged commit eda1f11 into BoostIO:master Dec 13, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 13, 2017

Merged. Thanks for your support! @Hooskers @sota1235

@wadjoh
Copy link
Contributor Author

wadjoh commented Dec 13, 2017

Awesome, thanks! I'm a big fan of Boostnote and see a lot of areas of improvement. Look forward to seeing more PRs from me in the future! 😄

@wadjoh wadjoh deleted the add-scroll-past-end branch December 13, 2017 16:30
@kazup01
Copy link
Member

kazup01 commented Dec 13, 2017

@Hooskers Cool! We are looking forward to your suggestion <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants