Skip to content

Conversation

jandom
Copy link
Collaborator

@jandom jandom commented Nov 11, 2023

I have again paired with my coding robot and managed to hammer out some nice fix – plus a test!

@jandom jandom changed the title Jandom/fix/252 handle keyboard interrupts fix #252: handle keyboard interrupts Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #270 (01241b0) into main (10516d0) will increase coverage by 0.05%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   69.20%   69.26%   +0.05%     
==========================================
  Files          22       22              
  Lines        3949     3966      +17     
  Branches      715      717       +2     
==========================================
+ Hits         2733     2747      +14     
- Misses       1036     1038       +2     
- Partials      180      181       +1     
Files Coverage Δ
gromacs/run.py 70.06% <72.72%> (+1.60%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that tests are happy, just add an entry to CHANGES.

You and your 🤖 are on a role. Maybe I have to update my priors regarding 🤖s.

@jandom jandom requested a review from orbeckst November 13, 2023 07:50
@jandom
Copy link
Collaborator Author

jandom commented Nov 13, 2023

All changed now @orbeckst

@orbeckst orbeckst self-assigned this Nov 15, 2023
@orbeckst orbeckst merged commit 9ecbdea into Becksteinlab:main Nov 15, 2023
@orbeckst orbeckst linked an issue Nov 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle KeyboardInterrupts when using MDRunner.run()
2 participants