Fix: __powerline_last_status_prompt to handle unset argument safely #2331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small bug in the
__powerline_last_status_promptfunction wherean error would occur if the function was called without an argument.
Changes
${1?}with${1:-0}to provide a safe default value when$1is unset.Why
The previous implementation used
${1?}, which causes error to show up before each promptif
$1is not set. This could break the prompt in certain cases. By switching to${1:-0}, the function now defaults to0and continues safely.Testing