Skip to content

Conversation

@shinenelson
Copy link
Contributor

resolves #2314

How Has This Been Tested?

Tested in docker container

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@seefood seefood self-assigned this Jun 17, 2025
@seefood seefood marked this pull request as draft June 17, 2025 09:38
@seefood
Copy link
Contributor

seefood commented Jul 13, 2025

hey Shine, are you fixing the bats test?

@shinenelson
Copy link
Contributor Author

I tried fixing most of the test failures that showed up. But I have not been able to find the time to resolve the remaining failures, unfortunately.

@seefood seefood marked this pull request as ready for review October 7, 2025 13:22
seefood and others added 3 commits October 7, 2025 16:29
Updates all remaining test file references to reflect the rename from
todo.txt-cli.aliases.bash to todo.aliases.bash. This completes the
consistency improvements started in the main PR.

Changes:
- Updated test names to use "todo" instead of "todo.txt-cli"
- Updated symlink paths in test setup
- Updated assertions to expect new filename
- All 69 tests pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Update test expectations to use priority 750 (default for aliases) instead
of 150. The todo.aliases.bash file doesn't specify a custom priority, so it
uses BASH_IT_LOAD_PRIORITY_ALIAS which defaults to 750.

Changes:
- Updated helpers.bats test expectations from 150 to 750
- Updated completion tests from 150 to 750
- All 69 helpers tests now pass
- All 46 completion tests now pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@seefood seefood merged commit c8acca7 into Bash-it:master Oct 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: interative install fails to install todo aliases

2 participants