Lots of little fixes because I screwed up the clean_files.txt and missed unlinted completions #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @akinomyoga, if you feel like taking a look. |
akinomyoga
reviewed
Mar 22, 2025
Co-authored-by: Koichi Murase <[email protected]>
Co-authored-by: Koichi Murase <[email protected]>
…nto ira/completion-cleanup * 'ira/completion-cleanup' of github.com:Bash-it/bash-it: Update completion/available/rvm.completion.bash
akinomyoga
reviewed
Mar 23, 2025
Co-authored-by: Koichi Murase <[email protected]>
akinomyoga
reviewed
Mar 23, 2025
Co-authored-by: Koichi Murase <[email protected]>
Co-authored-by: Koichi Murase <[email protected]>
akinomyoga
approved these changes
Mar 23, 2025
Contributor
akinomyoga
left a comment
akinomyoga
left a comment
There was a problem hiding this comment.
After fixing these, I'm fine with merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaning up completions to please the shellcheck gods.
Motivation and Context
directory
completion/was not tested due to a typo, and now it is, and I hope to have fixed the completions.How Has This Been Tested?
Nada. I am not a user of any of those commandline tools. I am just happy this passes the linters.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.