Skip to content

Conversation

@seefood
Copy link
Contributor

@seefood seefood commented Nov 5, 2024

Description

a theme file breaks shellcheck linting for my other PR, fixing it even though it's not my code.

Motivation and Context

unrelated PRs fail the lint test otherwise.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@seefood seefood merged commit d49c51a into Bash-it:master Nov 5, 2024
2 of 6 checks passed
@seefood seefood deleted the ira/shellcheck_fix branch November 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant