Skip to content

Improve git aliases #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seefood merged 3 commits into from
Nov 6, 2024
Merged

Improve git aliases #2176

seefood merged 3 commits into from
Nov 6, 2024

Conversation

@royatt
Copy link
Contributor

@royatt royatt commented Dec 2, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@royatt royatt force-pushed the improve-git-aliases branch from a56b6b3 to 54cdf3a Compare December 2, 2022 19:33
@royatt royatt marked this pull request as draft December 2, 2022 20:18
@royatt royatt changed the title Draft: Improve git aliases Improve git aliases Dec 2, 2022
@royatt
Copy link
Contributor Author

royatt commented Dec 3, 2022

@NoahGorny

cornfeedhobo
cornfeedhobo reviewed Dec 3, 2022
View reviewed changes
aliases/available/git.aliases.bash Outdated
else
echo master
fi
git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remotes/origin/@@'
Copy link
Member

@cornfeedhobo cornfeedhobo Dec 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use a bash substitution instead of farming out to sed?

Copy link
Contributor Author

@royatt royatt Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is very much possible, good idea, changed it in the newest commit.
think I should squash it down later with the original commit if it looks good

NoahGorny
NoahGorny reviewed Dec 3, 2022
View reviewed changes
@royatt royatt force-pushed the improve-git-aliases branch 2 times, most recently from d9c339c to 949309d Compare December 5, 2022 20:19
@royatt royatt marked this pull request as ready for review December 23, 2022 18:52
@royatt royatt force-pushed the improve-git-aliases branch from 949309d to d9c339c Compare February 17, 2024 21:47
@seefood seefood merged commit a80d898 into Bash-it:master Nov 6, 2024
@royatt royatt deleted the improve-git-aliases branch January 4, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cornfeedhobo cornfeedhobo cornfeedhobo left review comments

@NoahGorny NoahGorny NoahGorny left review comments

@seefood seefood seefood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@royatt @seefood @cornfeedhobo @NoahGorny