Skip to content

Conversation

@NoahGorny
Copy link
Member

Provide a default editor in case EDITOR and ALTERNATIVE_EDITOR are not defined

Motivation and Context

Closes #2123

How Has This Been Tested?

Locally, I can probably add a test of this

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@NoahGorny NoahGorny merged commit 60c4c0b into Bash-it:master Mar 16, 2022
@NoahGorny NoahGorny deleted the add-default-editor-nano branch March 16, 2022 19:47
@cornfeedhobo
Copy link
Member

cornfeedhobo commented Mar 17, 2022

@NoahGorny I'm not sure how I feel about this PR. I feel like vi is the correct fall back since it's the standard editor for most distros. However, I'm probably bike shedding and don't think the impact is big enough to really care. just my $0.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: bash: ALTERNATE_EDITOR: parameter not set

2 participants