Skip to content

Conversation

@NoahGorny
Copy link
Member

  • lib: preview: Load only bash-it.sh when previewing
  • lib: search: Increase delay in _bash-it-flash-term to 0.2 secs

Hi @gaelicWizard, seems like I bumped into a problem with bash-it preview. Please take a look!

Copy link
Contributor

@gaelicWizard gaelicWizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these changes look good to me.

(And I think I just outed myself as not having a theme enabled by default!)

@gaelicWizard
Copy link
Contributor

I'm thinking of rewriting _bash-it-flash-term(). I'd like it to be a generic print-and-flash. (Right now, it assumes the term has been printed once already and expects the length passed in.)

@NoahGorny NoahGorny merged commit a6fd930 into Bash-it:master Mar 8, 2022
@NoahGorny NoahGorny deleted the fix-preview branch March 8, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants