completions: clear and consistent log messages #2063
Merged
+353
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
lib/completion/components
branch
6 times, most recently
from
c319aa2 to
d119871
Compare
- `_bash-it-completion-helper-necessary()` - `_bash-it-completion-helper-sufficient()`
TODO: `pew` TODO: `source <(flutter bash-completion)` vs `eval $(flutter bash-completion)`...saves a subshell...
gaelicWizard
force-pushed
the
lib/completion/components
branch
from
d119871 to
1c2b0bc
Compare
Contributor
|
Howdie! please merge from master and resolve conflicts so we can move it to review :) |
seefood
added
clean up
seems abandoned
seefood
reviewed
Aug 24, 2025
akinomyoga
reviewed
Aug 24, 2025
| OPTS=$(dmidecode "$prev" 2>&1 | grep -E '^ ' | sed 's/ *//g') | ||
| # shellcheck disable=SC2207 | ||
| COMPREPLY=($(compgen -W "$OPTS" -- "$curr")) | ||
| COMPREPLY=("${OPTS[@]}") |
Contributor
There was a problem hiding this comment.
Is this correct? The assignment to OPTS is performed with the scalar form OPTS=$(...).
Also, I think OPTS should be localized within this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many plugins/completions/whatever check if their associated command is already installed before loading. Find, fix, and add in/to all the completions to ensure consistency and improve
bash-it doctor.Since completions are such a focused set of functions, create some helpers to simplify.
Motivation and Context
The
_command_exist()(et al) functions were all weird due to having logging shoved in sideways, which was neither informative nor used anywhere. This pulls the logging from the utility functions and adds it to the relevant call sites, as well as adding to several other plugins that could use it.In particular, some completions or some plugins may be useless but harmless if their associated command is not installed. I've opted to add logging, but not to force an early short-circuit. For example, I've made improvements to a lot of the completions code recently, but I don't have all the relevant tools installed. I load the completion and can test it out anyway, so I don't want to unnecessarily short-circuit it.
The result of all this should be a more reasonable output when
$BASH_IT_LOG_LEVELis set, and frombash-it doctor, as well as avoid polluting theme variables that check for installed utilities.How Has This Been Tested?
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.