Skip to content

Conversation

@gaelicWizard
Copy link
Contributor

Description

Change the functions in theme/powerline-multiline/powerline.base and theme/powerline/powerline.base to match more closely. Alsö, lint theme/powerline-multiline.

Motivation and Context

By updating them to match more closely, we may be able to eliminate the duplicate file in the future. It may be possible to just extend the main file to handle the use case of the alternative implementations.

How Has This Been Tested?

Since I haven't used the powerline* themes much, this is hard for me to test as I'm not used to what "normal" looks like.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard force-pushed the theme/powerline-multiline branch 5 times, most recently from 99d6b2a to 5390797 Compare January 24, 2022 20:00
@gaelicWizard gaelicWizard force-pushed the theme/powerline-multiline branch 3 times, most recently from 7010df9 to 7e87e76 Compare January 26, 2022 19:44
@gaelicWizard gaelicWizard force-pushed the theme/powerline-multiline branch 9 times, most recently from 87a9a23 to 0e7fade Compare February 13, 2022 07:23
@gaelicWizard gaelicWizard force-pushed the theme/powerline-multiline branch from 0e7fade to 5956ea2 Compare February 13, 2022 07:35
@gaelicWizard gaelicWizard changed the title theme/powerline-multiline: harmonize powerline.base files DRAFT: theme/powerline-multiline: harmonize powerline.base files Feb 20, 2022
@seefood seefood marked this pull request as ready for review April 30, 2025 11:29
@seefood seefood merged commit 1df68c1 into Bash-it:master Apr 30, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants