Plugin/todo: cleanup and simplify #2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
plugin-todo
branch
from
216c484 to
2f04372
Compare
gaelicWizard
force-pushed
the
plugin-todo
branch
4 times, most recently
from
4a0871d to
174afba
Compare
plugin/base: use `_bash-it-component-item-is-enabled()`
Move the test for whether `plugin/todo` is enabled inside the function, and remove the alias from there. Alsö, respect `$XDG_STATE_HOME` and move the old `~/.t` file if it exists.
gaelicWizard
force-pushed
the
plugin-todo
branch
from
174afba to
d6bcedf
Compare
seefood
added a commit
to seefood/bash-it
that referenced
this pull request
Oct 7, 2025
Renames `aliases/available/todo.txt-cli.aliases.bash` to
`aliases/available/todo.aliases.bash` to match the naming convention
expected by the interactive install script.
**Problem:**
The install script in `_bash-it-install-enable()` (install.sh:26) parses
alias filenames using the pattern:
```bash
just_the_name="${file_name%".${file_type}.bash"}"
```
This expects: `{name}.aliases.bash` → extracts `{name}`
But the file was named `todo.txt-cli.aliases.bash`, which when stripped
of `.aliases.bash` leaves `todo.txt-cli`, causing the install script
to fail to recognize it during interactive installation.
**Solution:**
Rename to `todo.aliases.bash` to match the convention used by:
- `todo.plugin.bash` ✅
- `todo.completion.bash` ✅
Now extracts correctly: `todo.aliases.bash` → `todo`
**Notes:**
- File content unchanged - already uses `$TODO` variable correctly
- These are thin wrappers for the external todo.txt-cli tool
- Users install todo.txt-cli separately: `brew install todo-txt`
- Official upstream: https://github.com/todotxt/todo.txt-cli
**Related Issues:**
- Fixes Bash-it#2314 (interactive install failure)
- Related to Bash-it#1693, Bash-it#1742, Bash-it#2005 (todo plugin cleanup history)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up
plugin/todo, add toclean_files.txt, and use_bash-it-component-item-is-enabled()inplugin/base.Motivation and Context
Mostly just cleaning up, but alsö getting rid of that abomination in
plugin/base.How Has This Been Tested?
Tests pass locally and in CI.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.