Wholesale cleanup of nodejs related components

[cornfeedhobo]

Description

• remove redundant cite
• support Basher
• add nenv plugin
• uplift nodenv to follow newer pattern and standard
• ensure node components play well with *env tools

Motivation and Context

I had to work on node and ran into these issues.

How Has This Been Tested?

locally

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[cornfeedhobo]

Does anyone have a strong feeling about leaving https:// in the about-plugin blurb?

Unfortunately the failing test is indicating an unrelated bug that should probably be addressed first.

Edit: I'm unable to reproduce the bug locally but I know I've seen bad search on ubuntu hosts before

cc @NoahGorny @davidpfarrell @gaelicWizard

[gaelicWizard]

In my helpers PR (#1934), I have some fixes related to bash-it search (via _bash-it-describe and boy is that code squirrelly); not sure if that's relevant to this test failure.

I don't have feelings about https:// (for once!)

[cornfeedhobo]

@gaelicWizard Unfortunately it appears that the search code is still broken :(

[gaelicWizard]

@cornfeedhobo, "management" contains the substring "gem":

$ bash-it show plugin |grep gem
nenv                 [ ]        Node.js environment management using https://github.com/ryuone/nenv
nodenv               [ ]        Node.js environment management using https://github.com/nodenv/nodenv
ruby                 [ ]        ruby and rubygems specific functions and settings

So, bash-it search gem returns nenv and nodenv.

[cornfeedhobo]

@gaelicWizard Hey I finally have a free weekend to think. Sorry I fired off that comment without taking a real look.

Yeah, I see today that search is checking descriptions, which is unexpected, but wfm. Thanks for pointing it out and saving me the hunting.

[NoahGorny]

what about logging a warning in the case we dont find nvm.sh?

[NoahGorny]

shouldnt we still check this?

[seefood]

Want to fix the merge conflicts and unresolved remarks from Noah?/

[seefood]

hey @cornfeedhobo, should I keep this open or throw away?

[cornfeedhobo]

oh boy. um... I can rebase sometime this week and give it a test against master... I hope. I am so swamped right now 😅 🫠

[seefood]

either rebase or a merge, up to you, and take your time :)

[seefood]

seems ok

[seefood]

hey man, just touching base...

[seefood]

need help with it? I would like to close a release 3.2 and I believe this deserves to be in there.

[seefood]

This PR has been waiting for 3 years and has significant merge conflicts with master. After reviewing the changes:

Already in Master:

• npm completion improvements (fixed via other PRs)
• nvm/node plugin improvements (incorporated in Fix todo.txt-cli alias install failure by renaming file #2348 and others)
• Most of the nodejs ecosystem cleanup work

Still Unique:

• nenv plugin addition

However, the nenv tool appears to be abandoned (last commit was 2017), so adding support for it may not provide value to users.

Recommendation: Close this PR as the valuable changes have been incorporated through other PRs over the past 3 years. If nenv support is still needed, it should be submitted as a standalone PR without the conflicts.