completion/wpscan: simplify code flow (whitespace) #1961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
completion-wpscan
branch
from
ad96e4d to
3af1aa4
Compare
davidpfarrell
approved these changes
Sep 22, 2021
Contributor
There was a problem hiding this comment.
Confirmed mostly just the early bailout, whitespace adjustments.
BUT also fixing array to be an actual array.
cc: @tbhaxor I think you and I broke this in #1898 where $_opt_ became the entire OPTS string ...
I'm going tentatively mark as approved but would like @tbhaxor to chime in before merging ...
gaelicWizard
force-pushed
the
completion-wpscan
branch
from
3af1aa4 to
057fdf6
Compare
Contributor
Author
|
I've rebased on current master, and changed |
Contributor
|
Q: Can we add this to [edit] Grammar |
Convert from indented if-block to return then unindented code. This should have basically one line change at the top, one line removed at the bottom, and then all whitespace.
gaelicWizard
force-pushed
the
completion-wpscan
branch
from
057fdf6 to
84c9666
Compare
Contributor
Author
Already is! 👍 |
davidpfarrell
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert from indented if-block to return then unindented code. This should have basically one line change at the top, one line removed at the bottom, and then all whitespace.
Motivation and Context
Just cleaning up.
How Has This Been Tested?
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.