Skip to content

plugin/proxy: lint #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NoahGorny merged 1 commit into from
Jan 18, 2022
Merged

plugin/proxy: lint #1958

NoahGorny merged 1 commit into from
Jan 18, 2022

Conversation

@gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Sep 20, 2021

Description

Adopt _command_exists, quote variables, handle unbound parameters, code flow simplification.

Motivation and Context

This was part of my _command_exists branch (#1938) but was out of scope.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard
Copy link
Contributor Author

gaelicWizard commented Sep 24, 2021 •
edited
Loading

(I'll rebase this one on master so as not to give @davidpfarrell an aneurism as soon as I get back to my computer ♥)

EDIT: Rebased and ready to go!

@gaelicWizard gaelicWizard marked this pull request as draft September 24, 2021 04:26
@gaelicWizard
Copy link
Contributor Author

gaelicWizard commented Sep 24, 2021

Actually, I'm marking this as draft. I'll circle back later

davidpfarrell
davidpfarrell reviewed Sep 24, 2021
View reviewed changes
@gaelicWizard gaelicWizard marked this pull request as ready for review January 9, 2022 08:09
@gaelicWizard
plugin/proxy: shellcheck && shfmt
6e480d7 
plugins/proxy: use `_command_exists()`

Alsö, quote variables, handle unbound parameters, &c.
NoahGorny
NoahGorny approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahGorny NoahGorny merged commit 973a1f9 into Bash-it:master Jan 18, 2022
@gaelicWizard gaelicWizard deleted the plugin-proxy branch January 18, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

+1 more reviewer

@davidpfarrell davidpfarrell davidpfarrell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaelicWizard @NoahGorny @davidpfarrell