-
Notifications
You must be signed in to change notification settings - Fork 2.3k
purity theme, added virtualenv name display #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If it's approved, will follow with a clean-up PR |
davidpfarrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the themes have their own venv detection logic, so adding one here is reasonable.
However, the detect_venv; PS1+=... approach seems outdated (although still used by some themes)
I suggest just echoing the value from within your method, leaving your PS1 definition more clean.
NOTE: I also recommend renaming detect_venv => venv_prompt
davidpfarrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one small comment but I think this is almost ready to go !
It occurs to me that now might be a good time to add This will allow our internal lint-checkers to run against the theme. |
davidpfarrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems great to me !
|
Well done @tiagobarros99 and great review @davidpfarrell 😄 |
Description
Added a function to show the name of the python virtualenv, when its being used.
Motivation and Context
I consider having the name of the virtual environment we're in very useful.
How Has This Been Tested?
Entering and leaving a virtualenv has the desired behaviour.
Screenshots (if appropriate):
Demo
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.