Skip to content

Conversation

@cornfeedhobo
Copy link
Member

Description

  • fix wildcards to include nested files (see the format docs)
  • include test/run in the bash section

Motivation and Context

  • I noticed that my personal editorconfig was taking over because the wildcards
  • I'm playing around with a new approach to running tests, and noticed test/run not respecting editorconfig styles

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@cornfeedhobo
Copy link
Member Author

I can also include a commit of test/run and test/test_helper.bash linted if you want, just let me know.

@cornfeedhobo cornfeedhobo requested a review from NoahGorny January 1, 2021 22:35
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, nice catch @cornfeedhobo!
I will merge this, and you are welcome to open up a following PR with the lints you suggested!

@NoahGorny NoahGorny merged commit 3addebb into Bash-it:master Jan 1, 2021
@cornfeedhobo cornfeedhobo deleted the editorconfig-fixes branch February 3, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants