Skip to content

Added comment to install "t" and disable "todo.plugin" #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoahGorny merged 2 commits into from
Dec 27, 2020
Merged

Added comment to install "t" and disable "todo.plugin" #1742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a14cfe0
Merge pull request #1 from Bash-it/master
russelltadams Dec 15, 2020
b6cea7b
Add comment to install "t" and disable "todo.plugin"
Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions themes/modern-t/modern-t.theme.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# The "modern-t" theme is a "modern" theme variant with support
# for "t", the minimalist python todo list utility by Steve Losh.
# Get and install "t" at https://github.com/sjl/t#installing-t
#
# Warning: The Bash-it plugin "todo.plugin" breaks the "t"
Copy link
Member

@NoahGorny NoahGorny Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer to fix the plugin and not add a warning here. I will try to fix it up in the upcoming days

Copy link
Contributor Author

@russelltadams russelltadams Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I think "t" is pretty well unknown, and unless I missed it, I see no readme for the "modern" themes. That would be a better place for this info to be. Would a readme doc for the modern themes be appreciated? I have come this far, I'd like to try to get a PR in if I can. I would think it should be here "bash-it/docs/themes-list/". I also noticed the screenshots for "modern-t" also show that "t" is not installed, as there is an error. This is kind of what I mean, most that might try modern-t have no idea that there is an actual dependence called "t", or even if they figure it out, it's not easy to find, sadly as it is a very good little utility.

Also, It would be easy to create a "todo.sh" variant, "modern-todo" with the same CLI integration functionality as "modern-t". I'd be happy to submit that one, but I am unsure how people feel about having multiple varients of the same theme.

Copy link
Member

@NoahGorny NoahGorny Dec 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a readme doc will be a great idea of you can do it- the location you assumed is the correct one as well!
I do not think we need another theme for that, but we might need to improve (and add) docs about "modern-t" and also maybe add a check that it indeed uses the "t" utility

# prompt integration, please disable it while using this theme.

SCM_THEME_PROMPT_PREFIX=""
SCM_THEME_PROMPT_SUFFIX=""

Expand Down