Skip to content

Conversation

@NoahGorny
Copy link
Member

After #1694
Cleaning up agnoster theme, works after my cleanup

@NoahGorny NoahGorny force-pushed the clean-agnoster-theme branch from e400324 to 3a5a8e0 Compare November 5, 2020 18:55
@NoahGorny NoahGorny force-pushed the clean-agnoster-theme branch from 3a5a8e0 to 24c1e98 Compare December 5, 2020 16:43
@NoahGorny NoahGorny force-pushed the clean-agnoster-theme branch from 24c1e98 to 7d288ba Compare January 1, 2021 22:51
@NoahGorny NoahGorny requested a review from cornfeedhobo January 1, 2021 22:51
@cornfeedhobo
Copy link
Member

@NoahGorny If this PR is solely to format, I'll approve it, but this theme does a bunch of stuff that I don't like, so I'd love to get an associated cleanup. Check out my discussion thread, as it's related.

@NoahGorny
Copy link
Member Author

@NoahGorny If this PR is solely to format, I'll approve it, but this theme does a bunch of stuff that I don't like, so I'd love to get an associated cleanup. Check out my discussion thread, as it's related.

I see
I think that if we already lint the theme, it's worthwhile to change things we wanna change. However, this can be achieved in a following PR, as the diff will be hard to review here

@NoahGorny NoahGorny force-pushed the clean-agnoster-theme branch from 467c0d1 to c168122 Compare January 7, 2021 17:12
@NoahGorny NoahGorny enabled auto-merge January 7, 2021 17:40
@NoahGorny NoahGorny merged commit d97a36a into Bash-it:master Jan 7, 2021
@NoahGorny NoahGorny deleted the clean-agnoster-theme branch January 7, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants