Skip to content

Conversation

@NoahGorny
Copy link
Member

This command will re exec the shell, yet cd to the prev pwd
I briefly floated the idea in #1665 (comment)
I still did not test this on Mac, and also I could not enable the --login option, as I wanted to run command after shell initialization. @ahmadassaf could you please test this and tell me if this works on Mac?

Also add completion and completion tests
@nwinkler
Copy link
Member

Just tried this on my MacBook, looks good to me:

image

Seems to work just fine.

@NoahGorny
Copy link
Member Author

Just tried this on my MacBook, looks good to me:

image

Seems to work just fine.

Thats great! I think this is a great addition to the set of abilities bash it has.
I want to merge this, what do you say @nwinkler 😄

@nwinkler
Copy link
Member

Agreed - this looks good! Thanks for adding this!

I'm wondering whether we want to include this in the documentation. I've checked the main README file, it currently does not provide a complete list of all commands (e.g. bash-it reload). We might want to add that at one point - probably as a separate PR when (hopefully at one point) rework the documentation.

@NoahGorny
Copy link
Member Author

Agreed - this looks good! Thanks for adding this!

I'm wondering whether we want to include this in the documentation. I've checked the main README file, it currently does not provide a complete list of all commands (e.g. bash-it reload). We might want to add that at one point - probably as a separate PR when (hopefully at one point) rework the documentation.

Created a new issue, in the meantime, I think we can merge this (and then #1626)

@nwinkler nwinkler merged commit 27702f6 into Bash-it:master Oct 16, 2020
@nwinkler
Copy link
Member

Merged! Thanks again for the work you put into this!

I'll let you handle #1626...

@NoahGorny NoahGorny deleted the bash-it-reset branch October 27, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants