helpers: Add --slient option to bash-it update #1621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ping @nwinkler |
NoahGorny
force-pushed
the
update-silent-option
branch
from
a2e504c to
83cdb40
Compare
added 2 commits
July 10, 2020 12:58
Also fix the update completion test
nwinkler
requested changes
Jul 12, 2020
Member
nwinkler
left a comment
nwinkler
left a comment
There was a problem hiding this comment.
Sorry about the delay in reviewing your PRs, apologies! I've left some comments - can you please take a look?
lib/helpers.bash
Outdated
| return;; | ||
| update) | ||
| func=_bash-it_update;; | ||
| _bash-it_update $component "$@" |
Member
There was a problem hiding this comment.
Why did you add the $component here? Is this really needed for the update scenario?
Member
Author
There was a problem hiding this comment.
removed in the currrent version
|
|
||
| declare silent | ||
| for word in $@; do | ||
| if [[ ${word} == "--silent" || ${word} == "-s" ]]; then |
Member
There was a problem hiding this comment.
Please add documentation for the two new options to the README.md file in the Updating section.
|
|
||
| declare silent | ||
| for word in $@; do | ||
| if [[ ${word} == "--silent" || ${word} == "-s" ]]; then |
Member
There was a problem hiding this comment.
Should we also add the new --silent option to the bash-it.completion.bash file? The update command is not covered at the moment, since it did not have any options so far.
NoahGorny
force-pushed
the
update-silent-option
branch
from
83cdb40 to
72cb996
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1523
Lemme know what you think @nwinkler 😄