Fix: Funktion key from config gets overwritten by function key in url #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinyoo
suggested changes
Mar 21, 2022
Contributor
justinyoo
left a comment
justinyoo
left a comment
There was a problem hiding this comment.
@Derich367 Would you please add some test codes to validate your changes?
Derich367
force-pushed
the
allow-function-specific-funktion-keys
branch
from
9ab333e to
108ec61
Compare
Contributor
Author
@justinyoo I added tests for this behaviour |
justinyoo
suggested changes
Mar 22, 2022
Contributor
justinyoo
left a comment
justinyoo
left a comment
There was a problem hiding this comment.
Thanks for adding the test method! I've left a couple of comments for you to take a look.
test/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/SwaggerUITests.cs
Show resolved
Hide resolved
test/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/SwaggerUITests.cs
Outdated
Show resolved
Hide resolved
… key to be set from query
Derich367
force-pushed
the
allow-function-specific-funktion-keys
branch
from
108ec61 to
0e3846a
Compare
Derich367
added a commit
to Derich367/azure-functions-openapi-extension
that referenced
this pull request
Jan 30, 2023
… key to be set from query (Azure#383) Co-authored-by: Simon Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #382