Fix null jsonBody serialization in HttpResponse #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an HTTP response with
jsonBody
set tonull
, the value should be serialized as"null"
(likeJSON.stringify(null)
), but it was being treated as undefined and no body or header was being set.Problem
The issue was in the
HttpResponse
constructor where it usedisDefined(init.jsonBody)
which returnsfalse
fornull
values, causing the response to fall back to usinginit.body
instead of properly serializing thenull
value as JSON.Solution
Changed the condition in
HttpResponse
constructor fromisDefined(init.jsonBody)
toinit.jsonBody !== undefined
to allownull
values to be properly serialized as JSON.Changes Made
src/http/HttpResponse.ts
to checkinit.jsonBody !== undefined
instead ofisDefined(init.jsonBody)
isDefined
importnull
serializes to"null"
with application/json content-typefalse
serializes to"false"
with application/json content-type0
serializes to"0"
with application/json content-typeThe fix ensures that all falsy but valid JSON values (
null
,false
,0
) are treated as valid JSON values that should be serialized, consistent with JavaScript'sJSON.stringify()
behavior.Fixes #325.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.