Move net461 build IdentityModel dependency to 4.X #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuxianc
approved these changes
Aug 28, 2018
JamesBirdsall
approved these changes
Aug 29, 2018
sjkwak
reviewed
Aug 30, 2018
| @@ -51,26 +51,30 @@ | |||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net461' "> | |||
| <Reference Include="System" /> | |||
| <Reference Include="Microsoft.CSharp" /> | |||
| <Reference Include="System.IdentityModel" /> | |||
| <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="4.0.4.402070948" /> | |||
sjkwak
reviewed
Aug 30, 2018
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> | ||
| <PackageReference Include="System.Reflection.TypeExtensions" Version="4.3.0" /> | ||
| <PackageReference Include="System.Runtime.Serialization.Primitives" Version="4.3.0" /> | ||
| <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="5.2.2" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdentityModel extensions 5.X doesn't support ASP.NET 4.X.
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/README.md
This checklist is used to make sure that common guidelines for a pull request are followed.