Skip to content

Conversation

@abdullah-kasim
Copy link
Contributor

Description

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change has relevant unit tests (if applicable).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Resolved conflicts:
- Kept upstream fire_ingestion_failure() signature (post_id, failure_code, details)
- Removed Logger calls from ingestion methods (as per original task)
- Preserved API implementation changes
@abdullah-kasim abdullah-kasim changed the title Vip 2488 ingest api clean up logs and implement pr recommendations in feat: Implement ingestion for Ingestion API Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants