-
Notifications
You must be signed in to change notification settings - Fork 296
ui - add static instance external appliance support for fqdn and wildcard in subdomain #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…card in subdomain Signed-off-by: aporss <[email protected]>
Summary of ChangesHello @ArtjomsPorss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the UI's capability to define 'External Appliance' static instances by extending the input validation. Previously limited to IP addresses and CIDR blocks, the system now accepts FQDNs, including those with wildcard subdomains, providing greater flexibility for users to specify external resources. This change primarily involves updating the validation regular expression and corresponding unit tests. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the validation for 'External Appliance' static instances by adding support for FQDNs and wildcards, which is a valuable addition. The implementation includes a comprehensive set of new tests to cover these changes. My review focuses on improving the maintainability of the new regular expression and refining the test code for better readability and efficiency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Artjoms Porss <[email protected]>
Signed-off-by: aporss <[email protected]>
Signed-off-by: aporss <[email protected]>
Signed-off-by: Artjoms Porss <[email protected]>
Description
Contribution Checklist: