Skip to content

Conversation

@ArtjomsPorss
Copy link
Contributor

Description

  • Update validation in UI to allow FQDNs when adding static instances of type External Appliance
  • Wildcard can be used in FQDN in place of top-level domains

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ArtjomsPorss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the UI's capability to define 'External Appliance' static instances by extending the input validation. Previously limited to IP addresses and CIDR blocks, the system now accepts FQDNs, including those with wildcard subdomains, providing greater flexibility for users to specify external resources. This change primarily involves updating the validation regular expression and corresponding unit tests.

Highlights

  • FQDN and Wildcard Support: The UI validation for 'External Appliance' static instances now supports Fully Qualified Domain Names (FQDNs) and allows the use of wildcards in subdomains.
  • Updated Validation Logic: The regular expression used for validating 'External Appliance' instances has been updated to accommodate both standard IPv4 CIDR formats and the newly supported FQDNs with optional wildcards.
  • Expanded Test Coverage: New unit tests have been added to constants.test.js to ensure the updated validation logic correctly handles various IPv4, FQDN, and wildcard scenarios, including both valid and invalid inputs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the validation for 'External Appliance' static instances by adding support for FQDNs and wildcards, which is a valuable addition. The implementation includes a comprehensive set of new tests to cover these changes. My review focuses on improving the maintainability of the new regular expression and refining the test code for better readability and efficiency.

ArtjomsPorss and others added 4 commits November 13, 2025 20:45
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Artjoms Porss <[email protected]>
Signed-off-by: aporss <[email protected]>
Signed-off-by: aporss <[email protected]>
Signed-off-by: Artjoms Porss <[email protected]>
@havetisyan havetisyan merged commit 22ee0ea into AthenZ:master Nov 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants