-
Notifications
You must be signed in to change notification settings - Fork 296
Implement sia provider for client assertion use cases for fetching access tokens #3122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cess tokens Signed-off-by: Henry Avetisyan <[email protected]>
Summary of ChangesHello @havetisyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant improvement for clients fetching access tokens using client assertions (JWTs) by providing a mechanism for automatic JWT generation. Previously, clients had to manually handle the assertion process, which complicated caching. The new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant enhancements by implementing ServiceIdentityProvider for client assertion use cases, allowing for automatic caching of access tokens when using JWT-based client assertions. This simplifies the use of the ZTS client in such scenarios. The changes include new ServiceIdentityJWTPrivateKeyProvider and ServiceIdentityJWTSecretProvider classes, updates to OAuthTokenRequestBuilder to integrate these providers, and corresponding example and test code modifications. The addition of commons-codec dependency is appropriate for hashing client assertions in cache keys. Overall, the implementation looks solid and addresses the described problem effectively.
Description
When fetching access tokens with using client assertion (jwt), there was no way for the client to automatically cache the access tokens since the assertion was provided as part of the access token call. We defined a couple of new methods in the ServiceIdentityProvider that would return the client assertion type and value (jwt) automatically based on either the private key or shared secret specified. It simplifies the use of zts client in these scenario.
The test example code has been updated to show how it can be used to fetch access tokens.
Contribution Checklist:
Attach Screenshots (Optional)