-
Notifications
You must be signed in to change notification settings - Fork 296
expose jag api functions in zts java client #3119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Henry Avetisyan <[email protected]>
Summary of ChangesHello @havetisyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the ZTS Java client by introducing robust support for JWT Authorization Grant (JAG) API functions. It refactors the token request building process into a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for JWT Authorization Grant (JAG) tokens by adding a new OAuthTokenRequestBuilder and refactoring the ZTSClient to use it. This is a significant and well-structured change that improves the client's capabilities. Additionally, it includes important bug fixes to prevent potential NullPointerExceptions in generated client code when handling HTTP headers. My review focuses on a likely copy-paste error in the new token methods, a potential issue with cache key generation, and a point of clarification in the prefetch logic. The inclusion of comprehensive new tests is a great addition.
clients/java/zts/src/main/java/com/yahoo/athenz/zts/OAuthTokenRequestBuilder.java
Show resolved
Hide resolved
Signed-off-by: Henry Avetisyan <[email protected]>
Description
part of #3100 support. expose the jag token support in java client
Contribution Checklist:
Attach Screenshots (Optional)