option to auto-expunge audit log entries from role/group log tables

[havetisyan]

Description

addresses issue #3113

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial feature to prevent the unbounded growth of audit log tables for roles and groups within the Athenz system. By allowing administrators to configure maximum limits and retention counts for these logs, the system can automatically expunge older entries, ensuring database performance and manageability without manual intervention. This directly addresses issue #3113, providing a robust solution for audit log maintenance.

Highlights

• Audit Log Expunging: Implemented automatic expunging of old audit log entries for roles and groups to manage database size.
• Configurable Limits: Introduced new system properties (athenz.zms.jdbc.audit_log_role_max_limit, athenz.zms.jdbc.audit_log_role_keep_count, athenz.zms.jdbc.audit_log_group_max_limit, athenz.zms.jdbc.audit_log_group_keep_count) to control the maximum number of entries and how many to retain.
• Database Logic: Added SQL queries and Java methods within JDBCConnection to count existing audit log entries and perform cleanup operations when limits are exceeded.
• Comprehensive Testing: Included new unit tests for JDBCConnection to validate the audit log limit enforcement logic and a new integration test (ZMSObjectAuditLogTest) to verify the end-to-end functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a valuable feature to automatically manage the size of role and group audit log tables by expunging old entries. The implementation is well-structured, adding new configuration properties and the corresponding logic in the JDBC store. The changes are accompanied by thorough unit and integration tests, ensuring the feature's correctness and reliability. I have one suggestion for a minor refactoring to reduce code duplication, but overall, this is a solid contribution.