remove filter validation for simple name for resource access list

[havetisyan]

Description

the filter attribute definition was changed in pr #3097 to be just a string but the server code was not removed that validates the value is a simple name.

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in the getResourceAccessList API by removing an outdated validation check. Previously, the filter parameter was expected to be a 'simple name' on the server side, despite its definition being updated in a prior PR to allow any string. This change ensures that the server correctly processes the filter parameter as a general string, resolving the discrepancy and improving API flexibility.

Highlights

• Validation Removal: Removed the server-side validation for the filter parameter in the getResourceAccessList method, which previously enforced a 'simple name' format.
• Consistency Fix: This change aligns the server's behavior with a previous update (PR convert filter argument in resource access list to string from SimpleName #3097) where the filter attribute definition was changed to accept any string, making the 'simple name' validation obsolete.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes obsolete validation logic for the filter parameter in the getResourceAccessList method. As described, a previous change modified the filter attribute to be a generic string, rendering the TYPE_SIMPLE_NAME validation incorrect. This change is a good cleanup that aligns the code with its intended functionality. The modification is straightforward and correct.