-
Notifications
You must be signed in to change notification settings - Fork 296
update go and java dependencies to their latest releases #3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Henry Avetisyan <[email protected]>
Summary of ChangesHello @havetisyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update of both Go and Java dependencies to their most recent releases. The primary goal is to leverage the latest features, performance improvements, and critical security fixes provided by these updated libraries, ensuring the project remains robust and up-to-date with current ecosystem standards. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several Go and Java dependencies to their latest releases. The changes are a good step towards keeping the project's dependencies up-to-date, which is important for security and maintainability. The updates in go.mod, go.sum, and pom.xml appear to be correct. I have one suggestion regarding the completeness of the Java dependency updates.
| <apache.httpclient4.version>4.5.14</apache.httpclient4.version> | ||
| <aws.version>1.12.792</aws.version> | ||
| <aws2.version>2.35.2</aws2.version> | ||
| <aws2.version>2.36.1</aws2.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's great that you're updating aws2.version, the PR title "update go and java dependencies to their latest releases" suggests a more comprehensive update. I noticed a few other Java dependencies that are outdated and could also be updated to their latest versions:
aws.version:1.12.792->1.12.800(latest patch)jjwt.version:0.11.5->0.12.5. Note: This is a major version update and may include breaking changes, so it would require careful testing.slf4j.client.version:1.7.36->2.0.17. This would align the client SLF4J version with the server version, which is good for consistency and avoiding potential classpath issues. This is also a major version update.
Updating these would make this PR more complete and further improve the project's security and maintenance posture. You might consider including these updates in this PR or addressing them in a follow-up.
Description
Contribution Checklist:
Attach Screenshots (Optional)