sysadmin delete domain tag support for skipping provider check

[havetisyan]

Description

Whenever a domain administrator deletes a domain, the server verifies that there are no dependencies on the domain before allowing the deletion to move forward. This also includes making external calls to registered providers.

However, there is no way to skip this option. If we ever come across a case, where the provider keeps reporting that the domain is in use due to some incorrect state, we're stuck and we can no longer delete the domain.Even the system admins can't delete the domain.

We now provide the capability for system admins to delete these domains with the use of Tags. So if we come across this case, the domain admin:

1. will add one of the system admins as a domain admin to delete the domain
2. a new tag with the name "zms.DeleteSkipServiceProviderCheck" and value "true"
3. delete the domain normally

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the domain deletion process within ZMS by providing system administrators with a critical override capability. Previously, domain deletions could be blocked indefinitely if external service providers reported an incorrect dependency state. The new functionality allows sysadmins to tag a domain with "zms.DeleteSkipServiceProviderCheck: true", enabling them to proceed with deletion, thereby ensuring system maintainability and resilience against external service inconsistencies.

Highlights

• New Domain Deletion Override: Introduced a mechanism for system administrators to bypass external service provider dependency checks during domain deletion.
• Tag-Based Control: The override is activated by applying a specific domain tag, "zms.DeleteSkipServiceProviderCheck", with a value of "true".
• Addresses Inconsistent States: This feature resolves issues where domains cannot be deleted due to external providers incorrectly reporting dependencies, providing a critical escape hatch for sysadmins.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a valuable feature for system administrators to bypass service provider dependency checks during domain deletion by using a specific tag. The implementation is solid, with new logic in ZMSImpl to conditionally skip the check based on the tag's presence and the user's privileges. The changes are well-supported by comprehensive tests, including a new integration test in ZMSDeleteDomainTest and unit tests for the tag-checking logic in ZMSTagTest. My review includes a couple of suggestions to enhance code clarity and maintainability.