-
Notifications
You must be signed in to change notification settings - Fork 296
initial support for exchaning jag tokens with access tokens #3103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Henry Avetisyan <[email protected]>
Summary of ChangesHello @havetisyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request lays the groundwork for integrating Identity Assertion Authorization Grant (JAG) functionality into Athenz's ZTS component. It introduces the necessary infrastructure to process and validate external JWTs, allowing them to be exchanged for Athenz access tokens. This enhancement significantly broadens ZTS's interoperability by enabling it to trust and leverage tokens issued by external identity providers, streamlining authorization workflows for services that rely on external authentication mechanisms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for exchanging JWT Authorization Grant (JAG) tokens for Athenz access tokens. The changes span across the auth_core and zts-server modules, introducing new classes like JwtsResolver and extending existing ones like AccessToken and JwtsHelper to handle JWT processing with configurable processors and multiple JWKS URI resolvers. The ZTS server implementation is updated to process these new JAG requests, including validation of the assertion and authorization of the requested scopes. The test coverage for the new functionality is comprehensive.
My review includes a few suggestions for minor refactoring to improve code maintainability and fix some typos to adhere to Java naming conventions.
libs/java/auth_core/src/main/java/com/yahoo/athenz/auth/token/jwts/JwtsResolver.java
Outdated
Show resolved
Hide resolved
libs/java/auth_core/src/main/java/com/yahoo/athenz/auth/token/jwts/JwtsSigningKeyResolver.java
Outdated
Show resolved
Hide resolved
libs/java/auth_core/src/main/java/com/yahoo/athenz/auth/token/jwts/JwtsSigningKeyResolver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Henry Avetisyan <[email protected]>
Description
This is the second PR to support Identity Assertion Authorization Grant support in ZTS #3100. We'll might be decide to include additional authorization checks in the future.
Contribution Checklist:
Attach Screenshots (Optional)