allow wildcard in first domain component of StaticWorkloadName

[abvaidya]

Description

name attribute in putStaticWorkload call is used to specify the a fqdn / ip / cidr / enterprise appliance role depending on the static workload type. In order to support FQDNNetworkPolicy using msd controller, the regex pattern for name needs to allow wildcard in the first domain component for fqdn. Its a deliberate decision to not allow wildcard anywhere but as the first component. Wherever applicable, there are server side validations to make sure appropriate value is entered.

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @abvaidya, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request allows the use of a wildcard in the first domain component of StaticWorkloadName across RDL, Java, and Go schemas, and includes new test cases to validate this behavior. A new CLAUDE.md file was also added.

Highlights

• PullRequestSummary: This pull request introduces the ability to use a wildcard character (*) in the first domain component of a StaticWorkloadName. This change is implemented across the RDL definition, Java schema, and Go client schema for the MSD (Microservice Discovery) component. Additionally, a new CLAUDE.md file has been added to provide guidance for AI assistants working with the repository.
• Intent: The primary intent of this pull request is to enhance the flexibility of StaticWorkloadName by allowing a wildcard in its first domain component. This enables broader matching capabilities for workload names, likely for improved service discovery or policy definition within the Athenz system.
• Changes: - Added CLAUDE.md: A new file providing project overview, development commands, architecture, and guidelines for AI code assistants.

• Modified core/msd/src/main/rdl/Names.tdl: Updated the StaticWorkloadName RDL type definition to include a new pattern \*\.({StaticWorkloadFQDN}), allowing a wildcard in the first domain component.
• Modified core/msd/src/main/java/com/yahoo/athenz/msd/MSDSchema.java: The Java schema for StaticWorkloadName was updated to reflect the new regex pattern, enabling *. prefix for workload names.
• Modified clients/go/msd/msd_schema.go: The Go client schema for StaticWorkloadName was similarly updated with the new regex pattern to support the wildcard in the first domain component.
• Modified core/msd/src/test/java/com/yahoo/athenz/msd/StaticWorkloadTest.java: Added new test cases to validate the updated StaticWorkloadName pattern, specifically ensuring that *.myhostname.subdomain.domain.com is considered valid, while patterns with wildcards in other positions or standalone wildcards are invalid.

• ReviewerActivity: No reviewer activity has been recorded yet for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This is a general comment that applies to the entire pull request.