Skip to content

Conversation

@havetisyan
Copy link
Collaborator

@havetisyan havetisyan commented Oct 6, 2025

Description

on the zts server side we have an parameter called openid_issuer that could be included in the access token request to request the server to include the configured issuer in the token. this attribute was not exposed in the java client so now it's been added. instead of adding more attributes, there is now a new AccessTokenRequestBuilder builder class object that can be included in the get access token request.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ZTS Java client by exposing the openid_issuer field for access token requests, allowing clients to explicitly request the configured OpenID issuer in the token. To improve the developer experience and manage the growing number of access token parameters, a new AccessTokenRequestBuilder has been introduced, providing a more structured and fluent way to construct access token requests.

Highlights

  • Exposed openid_issuer field: The openid_issuer parameter, previously only available on the ZTS server, is now exposed in the Java client for access token requests, allowing clients to explicitly request the configured OpenID issuer in the token.
  • New AccessTokenRequestBuilder: A new builder class (AccessTokenRequestBuilder) has been introduced to simplify the construction of access token requests, providing a fluent API for setting various parameters, including the new openid_issuer field.
  • Updated getAccessToken methods: Existing getAccessToken methods have been updated to accommodate the new openIdIssuer parameter, and a new overload accepting the AccessTokenRequestBuilder has been added for improved usability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully exposes the openid_issuer field for access tokens in the ZTS Java client. The introduction of the AccessTokenRequestBuilder is a great design choice to avoid further overloading the getAccessToken method, improving the client's usability and maintainability. The changes are well-implemented, and the tests have been updated accordingly to cover the new functionality, including a new comprehensive test for PrefetchTokenScheduledItem. My review includes one suggestion to improve the maintainability of a newly added test method by refactoring it into smaller, more focused tests.

@psasidhar psasidhar merged commit 9af8939 into master Oct 6, 2025
8 checks passed
@psasidhar psasidhar deleted the openid-issuer branch October 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants