GcsChangeLogStore implementation

[psasidhar]

Description

Providing a ChangeLogStore implementation for GCS for use in GCP

Contribution Checklist:

• [ x ] The pull request does not introduce any breaking changes
• [ x ] I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @psasidhar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly extends Athenz's cloud integration by providing a dedicated ChangeLogStore implementation for Google Cloud Storage (GCS). This allows Athenz to leverage GCS buckets for storing and retrieving domain change logs, enhancing its compatibility and operational efficiency within GCP environments. The changes also include necessary adjustments to private key handling to align with GCP's parameter naming conventions and a robust set of unit tests for the new components.

Highlights

• GCS ChangeLogStore Implementation: Introduced GcsChangeLogStore to enable Athenz to use Google Cloud Storage for managing change logs, including multi-threaded domain fetching.
• GCS ChangeLogStore Factory: Added GcsChangeLogStoreFactory for proper instantiation of the GCS change log store, requiring GCP project and bucket names.
• GCP Parameter Naming Convention: Modified PrivateKeyStoreUtil to adapt parameter naming conventions for GCP, replacing dots with underscores to comply with GCP's naming restrictions.
• Comprehensive Testing: New unit tests were added for the GcsChangeLogStore, GcsChangeLogStoreFactory, and the updated PrivateKeyStoreUtil to ensure robustness and correctness of GCP integration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a GcsChangeLogStore implementation to enable Athenz integration with Google Cloud Storage. The changes are a good starting point, but I've identified several issues that need to be addressed. There is a critical bug in getLocalDomainList that prevents it from functioning correctly. Additionally, there are high-severity issues related to unsafe parsing of system properties and a potential NullPointerException when handling blob metadata. I've also found several medium-severity issues, including copy-paste errors from the S3 implementation, generic exception handling, and other unsafe parsing. Please review the detailed comments for suggestions on how to resolve these problems.