provide option to skip error metrics

[havetisyan]

Description

By default, the zts and zms servers report error metrics with name format: ERROR, error_{error_code}, and {caller}error{error_code} any time there is a failure. However, if the administrator is not looking at these metrics, they're just wasted and there is no point of generating these metrics.

We now have a per service property setting that if set to true well disable reporting these metrics. The default value is false to maintain current functionality

athenz.zms.skip_error_metrics=false
athenz.zts.skip_error_metrics=false

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a new configuration option for both ZMS and ZTS servers, enabling administrators to selectively disable the reporting of error metrics. This enhancement aims to reduce unnecessary metric generation in environments where these specific error metrics are not actively monitored, thereby optimizing resource utilization. The default behavior of reporting metrics remains unchanged to ensure backward compatibility.

Highlights

• New Configuration Property: Introduced a new configuration property, athenz.zms.skip_error_metrics for ZMS and athenz.zts.skip_error_metrics for ZTS, allowing administrators to control error metric reporting.
• Disable Error Metrics: When the new property is set to true, the ZMS and ZTS servers will no longer report error metrics with formats like ERROR, error_{error_code}, and {caller}_error_{error_code}.
• Default Behavior Maintained: The default value for the skip_error_metrics property is false, ensuring that error metrics continue to be reported by default, maintaining current functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a valuable feature to optionally disable error metrics in ZMS and ZTS servers, which can help reduce unnecessary metric generation. The implementation is straightforward and consistent across both services.

My review focuses on improving the maintainability of this new configuration. I've suggested making the new properties dynamic, similar to other properties in the project. This would allow administrators to enable or disable these metrics without needing to restart the servers.