Separating GCP SyncLauncher into its own project under "syncers"

[psasidhar]

Description

Moving GCP SyncLauncher into its own project to maintain separation from AWS.

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @psasidhar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the modularity of the domain synchronization process by isolating the GCP SyncLauncher into its own dedicated project. This change improves the maintainability and clarity of the codebase by preventing interdependencies between cloud-specific synchronization logic, specifically separating GCP from AWS components. The primary goal is to create a more organized and scalable architecture for future cloud integrations.

Highlights

• New GCP Domain Syncer Module: A new Maven module, "athenz-zms-gcp-domain-syncer", has been introduced under the syncers directory to house GCP-specific domain synchronization logic, ensuring clear separation from AWS-related components.
• GCP Code Migration and Refactoring: Existing GCP-related code, including GcpZmsSyncerHelper.java and SyncLauncher.java, has been moved from the AWS domain syncer project to the newly created GCP domain syncer module. This migration also involved refactoring package names from com.yahoo.athenz.zms_gcp_domain_syncer to io.athenz.syncer.gcp for better organization and consistency.
• AWS Module Cleanup: The pom.xml for the zms_aws_domain_syncer module has been cleaned up by removing GCP-specific dependencies and general dependencies that are now handled by common syncer libraries, streamlining its build configuration.
• Updated Test Infrastructure: Corresponding test files and resources for the GCP domain syncer have been moved and added to the new module, including SyncHelperTest.java, SyncLauncherTest.java, and various configuration and key files, ensuring proper testing for the separated GCP functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively separates the GCP SyncLauncher into its own dedicated project, which is a significant improvement for modularity and maintainability. The changes are generally clean and well-structured. However, I've identified a critical issue in the test suite for the new GCP syncer module where a test was likely copied from the AWS syncer and not fully adapted, causing it to be broken. Additionally, there's a minor issue with some dead code in another test file. Addressing these points will ensure the new module is robust and well-tested.

[gemini-code-assist]

The field classLoader is initialized but never used. It should be removed to avoid confusion and dead code.