locale-independent message regex

[frumioj]

Description

My computer/shell runs with US/Spanish locale, which breaks the athenz build in the test I am changing here. Since you already pick the specific exception you're tracking, I think it's sufficient to have the message just contain the filename you're expecting not to be found, so I altered the regex in the @test

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @frumioj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a test failure in the KeyStoreCertSignerFactoryTest that occurred due to locale-dependent error messages. The change modifies the regular expression used in the test's expectedExceptionsMessageRegExp to be more robust and locale-agnostic. By replacing a specific error message string with a wildcard, the test will now correctly identify the expected exception regardless of the system's language settings, ensuring consistent build results across different environments.

Highlights

• Locale-Independent Test Regex: The expectedExceptionsMessageRegExp in the testCreateFileNotFound method was updated to use a more generic regex .*/keystore.pkcs12.not_exist \(.*\). This change replaces the hardcoded locale-specific message (No such file or directory) with a wildcard (.*), allowing the test to pass regardless of the operating system's locale settings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a locale-dependent test failure by making the expected exception message regex more generic. This is a good change that improves the robustness of the test suite across different environments. I have one suggestion to make the regular expression slightly more specific while retaining its locale-independent nature.

[gemini-code-assist]

While using (.*) makes the test locale-independent, it's a bit too broad and could potentially match more than intended if the error message format changes unexpectedly. A more specific, yet still locale-independent, regex would be [^)]*. This ensures that we only match the content within a single pair of parentheses.

Suggested change

	@Test(expectedExceptions = { RuntimeException.class, FileNotFoundException.class }, expectedExceptionsMessageRegExp = ".*/keystore.pkcs12.not_exist \\(.*\\)")
	@Test(expectedExceptions = { RuntimeException.class, FileNotFoundException.class }, expectedExceptionsMessageRegExp = ".*/keystore.pkcs12.not_exist \\([^)]*\\)")

[frumioj]

Full build error is in code unrelated to my change FWIW...

[havetisyan]

Thanks @frumioj, looks like the builds were successful, but it's not signed off. please check the DCO line below and sign off on the PR.

[frumioj]

Added my signoff to the PR and synced my fork. Thanks!