move assertionDomainCheck method to server common library

[havetisyan]

Description

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the "assertionDomainCheck" utility method by moving it from the ZMS server-specific utilities to the common server library. This change promotes code reusability and better architectural separation, allowing other components to utilize this domain validation logic.

Highlights

• Method Relocation: The "assertionDomainCheck" method has been moved from "ZMSUtils" in the ZMS server module to the more generic "Utils" class within the "server_common" library.
• Dependency Updates: All existing call sites for "assertionDomainCheck" in "AwsAssumeRoleResourceUpdater" and "GcpAssumeRoleResourceUpdater" have been updated to reference the method from its new location in the "Utils" class.
• Test Relocation: The corresponding unit tests for "assertionDomainCheck" have been moved from "ZMSUtilsTest" to a newly created "UtilsTest" class in the "server_common" library, ensuring the moved functionality remains well-tested.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the assertionDomainCheck method by moving it from ZMSUtils to the more general Utils class in the server_common library. The change is well-contained, updating the call sites and moving the corresponding test case. This is a good improvement for code organization. I've provided one suggestion to improve the implementation of the moved method for better efficiency and readability.