fix: preserve existing group members when applying domain templates

[chandrasekhar1996]

Description

When applying domain templates via putDomainTemplate API, existing group
members were being deleted if they weren't specified in the template. This
behavior was inconsistent with how roles are handled, where existing members
are preserved and only new template members are added.

Changes:

• Add ignoreDeletes parameter to processGroup() and processUpdateGroupMembers()
• Update template processing to pass ignoreDeletes=true for groups (matching roles)
• Preserve existing behavior for regular group operations (ignoreDeletes=false)
• Update processUpdateGroupMembers() to skip member deletion when ignoreDeletes=true

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @chandrasekhar1996, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in how group members are handled when applying domain templates. Previously, existing group members not explicitly listed in a template were deleted, unlike roles where existing members are preserved. This change modifies the group processing logic to align with role behavior, ensuring that applying a domain template to a group only adds new members from the template and preserves any existing members not specified.

Highlights

• Parameter Addition: Introduced an ignoreDeletes boolean parameter to processGroup and processUpdateGroupMembers methods in DBService.java to control member deletion behavior.
• Template Alignment: Modified the addSolutionTemplate method to pass ignoreDeletes=true when processing groups, ensuring that existing group members are preserved during template application.
• Behavior Preservation: Ensured that standard group operations via executePutGroup continue to pass ignoreDeletes=false, maintaining the existing behavior of removing members not specified in the update.
• Conditional Deletion Logic: Updated processUpdateGroupMembers to conditionally skip the deletion of group members based on the value of the ignoreDeletes flag.
• Comprehensive Testing: Added new unit tests (testProcessGroupIgnoreDeletes and testProcessGroupWithDeletes) to DBServiceTest.java to thoroughly validate both the new "ignore deletes" behavior for templates and the preserved "process deletes" behavior for regular group updates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue where applying domain templates to groups would delete existing members. The introduction of an ignoreDeletes flag is a clean solution that aligns group template behavior with that of roles. The changes are well-contained and the new tests adequately cover both the new functionality and the preservation of existing behavior. I've added a couple of suggestions to make the new tests more specific and robust.