expose on-call URL value in client-side config

[tsultanov00]

Description

• Remove NEXT_PUBLIC env var since these are baked during build time
• Read on-call URL from app config and export it for use in client-config
• Create client-config to expose on-call URL

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @tsultanov00, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how the on-call URL is exposed to the client-side in the UI application. It moves away from relying on NEXT_PUBLIC environment variables, which are baked in at build time, to a more robust client-side configuration mechanism using Next.js's publicRuntimeConfig. This ensures the onCallUrl is consistently available for client-side usage without being tied to the build process.

Highlights

• Configuration Refactor: The direct assignment of appConfig.onCallUrl or appConfig.serverURL to process.env.NEXT_PUBLIC_ONCALL_URL has been removed from ui/app.js, streamlining the configuration process.
• Next.js Public Runtime Config: A new next.config.js file was introduced to properly expose the onCallUrl via Next.js's publicRuntimeConfig, ensuring it's available for client-side use.
• Client-Side Configuration Abstraction: A new ui/src/config/client-config.js file was created to centralize and abstract access to client-side configuration values, specifically for the onCallUrl.
• Constants Update: The ONCALL_URL constant in ui/src/components/constants/constants.js now correctly retrieves its value from the newly established CLIENT_CONFIG instead of relying on process.env.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly refactors the application to expose the on-call URL to the client-side using Next.js's runtime configuration instead of build-time environment variables. This is a good improvement for configuration flexibility. The implementation is solid, but I've identified a potential issue where the changes could break the existing test suite. I've added a review comment with a detailed explanation and a suggested fix to ensure the tests continue to run reliably.

[ArtjomsPorss]

lgtm