Skip to content

handle 404 when principal is not part of any roles #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
havetisyan merged 1 commit into from
Aug 20, 2025
+36 −24
Merged

handle 404 when principal is not part of any roles #3052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 36 additions & 24 deletions ui/src/server/handlers/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3233,14 +3233,18 @@ Fetchr.registerService({
},
(err, list) => {
if (err) {
debug(
`principal: ${req.session.shortId} rid: ${
req.headers.rid
} Error from ZMS while calling getResourceAccessList API: ${JSON.stringify(
errorHandler.fetcherError(err)
)}`
);
callback(errorHandler.fetcherError(err));
if (err.status === 404) {
callback(null, []);
} else {
debug(
`principal: ${req.session.shortId} rid: ${
req.headers.rid
} Error from ZMS while calling getResourceAccessList API: ${JSON.stringify(
errorHandler.fetcherError(err)
)}`
);
callback(errorHandler.fetcherError(err));
}
} else {
if (!list || !list.resources) {
callback(null, []);
Expand All @@ -3264,14 +3268,18 @@ Fetchr.registerService({
{ principal: principal },
(err, data) => {
if (err) {
debug(
`principal: ${req.session.shortId} rid: ${
req.headers.rid
} Error from ZMS while calling getRolesForReview API: ${JSON.stringify(
errorHandler.fetcherError(err)
)}`
);
callback(errorHandler.fetcherError(err));
if (err.status === 404) {
callback(null, []);
} else {
debug(
`principal: ${req.session.shortId} rid: ${
req.headers.rid
} Error from ZMS while calling getRolesForReview API: ${JSON.stringify(
errorHandler.fetcherError(err)
)}`
);
callback(errorHandler.fetcherError(err));
}
} else {
if (!data || !data.list) {
callback(null, []);
Expand All @@ -3295,14 +3303,18 @@ Fetchr.registerService({
{ principal: principal },
(err, data) => {
if (err) {
debug(
`principal: ${req.session.shortId} rid: ${
req.headers.rid
} Error from ZMS while calling getGroupsForReview API: ${JSON.stringify(
errorHandler.fetcherError(err)
)}`
);
callback(errorHandler.fetcherError(err));
if (err.status === 404) {
callback(null, []);
} else {
debug(
`principal: ${req.session.shortId} rid: ${
req.headers.rid
} Error from ZMS while calling getGroupsForReview API: ${JSON.stringify(
errorHandler.fetcherError(err)
)}`
);
callback(errorHandler.fetcherError(err));
}
} else {
if (!data || !data.list) {
callback(null, []);
Expand Down
Loading