cloudsso - make api resource access call cloudsso and fallback to zms #3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aporss <[email protected]>
Signed-off-by: aporss <[email protected]>
Signed-off-by: Artjoms Porss <[email protected]>
Signed-off-by: aporss <[email protected]>
Signed-off-by: aporss <[email protected]>
abvaidya
approved these changes
Aug 21, 2025
abvaidya
requested changes
Aug 21, 2025
ui/src/server/clients.js
Outdated
| msd: CLIENTS.msd(req, setCookieinClients(req)), | ||
| zts: CLIENTS.zts(req, setCookieinClients(req)), | ||
| ums: CLIENTS.ums(req, setCookieinClients(req)), | ||
| cloud_sso: CLIENTS.zms(req, setOktaCookieinClients(req)), |
Collaborator
There was a problem hiding this comment.
it might be a better idea to create a separate client for cloud_sso but point it to zms rdl. Also is this the first cloud_sso is being referenced in here? If yes, lets add a small comment on the rationale behind CLIENTS.cloud_sso
Signed-off-by: aporss <[email protected]>
ArtjomsPorss
commented
Aug 21, 2025
Comment on lines
+59
to
+66
| // cloud_sso is a cache of zms's resource access lists | ||
| CLIENTS.cloud_sso = rdlRest({ | ||
| apiHost: config.cloud_sso, | ||
| rdl: require('../config/zms.json'), | ||
| requestOpts: { | ||
| strictSSL: config.strictSSL, | ||
| }, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
@abvaidya added separate client and comment as requested
Signed-off-by: aporss <[email protected]>
Signed-off-by: aporss <[email protected]>
abvaidya
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
call cloud sso for resource access list, fallback to zms on error
Contribution Checklist: