replace business service functionality with on-call team link #3032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsultanov00
force-pushed
the
rootly-oncall-id
branch
2 times, most recently
from
0138490 to
578e5da
Compare
Signed-off-by: Timur Sultanov <[email protected]>
tsultanov00
force-pushed
the
rootly-oncall-id
branch
from
578e5da to
da132fd
Compare
| const nextApp = next({ dev }); | ||
| const debug = require('debug')('AthenzUI:server:app'); | ||
|
|
||
| process.env.NEXT_PUBLIC_ONCALL_URL = appConfig.onCallUrl || appConfig.serverURL; |
Contributor
There was a problem hiding this comment.
apologies for the broken review, didn't notice it before
we do not have onCallUrl or serverURL in default-config.js.
Contributor
Author
There was a problem hiding this comment.
Henry mentioned that we shouldn't expose internal on-call links so that was moved to the internal config. With regards to serverUrl, I could just change that to a generic fallback url i.e https://example.com
chandrasekhar1996
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
Attach Screenshots (Optional)