ParameterManagerPrivateKeyStore implementation for KeyStore using GCP Parameter Manager #3030
Conversation
psasidhar
force-pushed
the
gcp_keystore
branch
7 times, most recently
from
8eb78fb to
80c4496
Compare
| private static final String ZTS_SERVICE = "zts"; | ||
| private static final String MSD_SERVICE = "msd"; | ||
|
|
||
| private static final String ATHENZ_PROP_ZMS_KEY_NAME = "athenz.aws.zms.key_name"; |
There was a problem hiding this comment.
For the key names, we should make them cloud specific. It's not right to say I have a keystore implementation for gcp but my property name is based on aws. So it should be:
"athenz." + cloud + "." + service + ".key_name"
add add the cloud as an argument to the getPrivateKeyFromCloudParameter method
There was a problem hiding this comment.
Good point. Updated the code.
libs/java/server_gcp_common/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>libraries-bom</artifactId> | ||
| <version>26.64.0</version> |
There was a problem hiding this comment.
we should not hard code the version here but use the version parameter from the main pom.xml
| return ParameterManagerClient.create(); | ||
| } | ||
|
|
||
| String apiEndpoint = String.format("parametermanager.googleapis.com:443", location); |
There was a problem hiding this comment.
where is location used?
There was a problem hiding this comment.
Oversight. Matched the non-global location endpoint with the documentation here.
https://cloud.google.com/secret-manager/parameter-manager/docs/list-parameter-versions
Still working with Google Support for testing this with real values in us-central1.
| } | ||
|
|
||
| public static boolean isGlobalLocation(String location) { | ||
| return "global".equalsIgnoreCase(location); |
There was a problem hiding this comment.
we use "global" in a couple of places so we should probably define as a static const
| <relativePath>../../../pom.xml</relativePath> | ||
| </parent> | ||
|
|
||
| <groupId>com.yahoo.athenz</groupId> |
There was a problem hiding this comment.
let' define a code coverage block as well - hopefully with 100% coverage
… Parameter Manager Signed-off-by: Sasi Palaka <[email protected]>
2 participants
Description
Providing KeyStore implementation for GCP using Parameter Manager
Moving common code among Cloud Parameter storage into a static methond in a Util class that can be reused
Contribution Checklist: