Skip to content

Install monitoring #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amar3tto merged 1 commit into from
Mar 20, 2025
Merged

Install monitoring #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/beam_Python_CostBenchmarks_Dataflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ jobs:
# The env variables are created and populated in the test-arguments-action as "<github.job>_test_arguments_<argument_file_paths_index>"
- name: get current time
run: echo "NOW_UTC=$(date '+%m%d%H%M%S' --utc)" >> $GITHUB_ENV
- name: Install Google Cloud Monitoring
run: python3.10 -m pip install google-cloud-monitoring
- name: Run wordcount on Dataflow
uses: ./.github/actions/gradle-command-self-hosted-action
timeout-minutes: 30
Expand Down
2 changes: 0 additions & 2 deletions sdks/python/apache_beam/testing/load_tests/dataflow_cost_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ def __init__(


def run(self) -> None:
"""Runs the pipeline and collects cost and additional metrics."""
try:
self.test()
if not hasattr(self, 'result'):
Expand Down Expand Up @@ -127,7 +126,6 @@ def _retrieve_cost_metrics(self, result: DataflowPipelineResult) -> dict[str, An


def _process_metrics_list(self, metrics: list) -> dict[str, Any]:
"""Processes system metrics from pipeline results."""
system_metrics = {}
for entry in metrics:
metric_key = entry.key
Expand Down